Fix for issue - #2808: Invalid type WSGIRequest for attribute 'request' value opentelemetry #3731
+112
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instrumentation/opentelemetry-instrumentation-django/tests/test_middleware.py
Outdated
Show resolved
Hide resolved
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Outdated
Show resolved
Hide resolved
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Outdated
Show resolved
Hide resolved
tammy-baylis-swi
approved these changes
Sep 3, 2025
There was a problem hiding this comment.
Thanks again @rads-1996 , this lgtm. Maintainers will also have a look.
Thank you so much. Really appreciate the review :) |
xrmx
reviewed
Sep 8, 2025
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Sep 8, 2025
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Sep 8, 2025
...nstrumentation-django/src/opentelemetry/instrumentation/django/middleware/otel_middleware.py
Outdated
Show resolved
Hide resolved
xrmx
moved this from Ready for review
to Reviewed PR that needs fixing
in @xrmx's Python PR digest
xrmx
moved this from Reviewed PR that needs fixing
to Ready for review
in @xrmx's Python PR digest
…y-python-contrib into django-issue-fix
…y-python-contrib into django-issue-fix
rads-1996
force-pushed
the
django-issue-fix
branch
from
ec091ea to
27498de
Compare
…y-python-contrib into django-issue-fix
xrmx
reviewed
Oct 10, 2025
| for _, value_list in attributes.items(): | ||
| for index, value in enumerate(value_list): | ||
| if isinstance(value, HttpRequest): | ||
| try: |
There was a problem hiding this comment.
Isn't str(value) enough instead of poking with HttpRequest internals?
There was a problem hiding this comment.
@xrmx Fixed the logic.
xrmx
reviewed
Oct 10, 2025
rads-1996
force-pushed
the
django-issue-fix
branch
from
c9b002b to
d7f1ce0
Compare
rads-1996
force-pushed
the
django-issue-fix
branch
from
9784d0a to
08e817c
Compare
rads-1996
force-pushed
the
django-issue-fix
branch
from
0bce4fd to
c79c917
Compare
emdneto
reviewed
Oct 14, 2025
There was a problem hiding this comment.
Thanks for the research and the PR, but I'm not sure if the issue is fixed. I'm still able to reproduce it, because Django logging extension (django.request and django.server) is still adding request to extras, which causes logs to be emitted with a request attribute containing an invalid value (WSGIRequest).
I didn't dig into it in detail, but what I imagine can solve the issue is to use a logging filter like:
class RequestFilter(logging.Filter):
def filter(self, record: logging.LogRecord) -> bool:
request = getattr(record, "request", None)
record.request = str(request)
return True
logger = logging.getLogger("django.request")
logger.addFilter(RequestFilter())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #2808
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.